Harald Welte has submitted this change and it was merged. (
https://gerrit.osmocom.org/11605 )
Change subject: bsc: gsm0808: Fix return code in bsc_compl_l3
......................................................................
bsc: gsm0808: Fix return code in bsc_compl_l3
complete_layer3 returns true if everything succeeded, false otherwise.
However, its caller bsc_compl_l3 returns unix style (0 sucess,
negative error).
This commit has no real effect since only caller of bsc_compl_l3 never
checks return code, but will check it in the future.
Change-Id: I722696c3f6402288b51d6fcf51f478b3b0c9f0f0
---
M src/osmo-bsc/gsm_08_08.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c
index 062c878..a3e8b30 100644
--- a/src/osmo-bsc/gsm_08_08.c
+++ b/src/osmo-bsc/gsm_08_08.c
@@ -366,7 +366,7 @@
return -1;
}
- return complete_layer3(conn, msg, msc);
+ return complete_layer3(conn, msg, msc) ? 0 : -2;
}
static int handle_page_resp(struct gsm_subscriber_connection *conn, struct
msgb *msg)
--
To view, visit https://gerrit.osmocom.org/11605
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I722696c3f6402288b51d6fcf51f478b3b0c9f0f0
Gerrit-Change-Number: 11605
Gerrit-PatchSet: 3
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-CC: Max <[email protected]>
