Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11681 )
Change subject: abis_nm: Add support to parse some nanoBTS Attribute Response attributes ...................................................................... Patch Set 2: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/11681/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11681/2//COMMIT_MSG@23 PS2, Line 23: first function to get a pointer to the list of attributes. this last bit seems to belong to a different patch? All I see in this patch is that you're directly parsing the attribute ID list without the Get Attributes Response Info. -- To view, visit https://gerrit.osmocom.org/11681 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52e9f177c14fec1ec3f5c4ddb244594409008357 Gerrit-Change-Number: 11681 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 08 Nov 2018 16:56:30 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
