Pau Espin Pedrol has submitted this change and it was merged. (
https://gerrit.osmocom.org/11681 )
Change subject: abis_nm: Add support to parse some nanoBTS Attribute Response
attributes
......................................................................
abis_nm: Add support to parse some nanoBTS Attribute Response attributes
nanoBTS actually supports regular formatting. There are a few differences
with spec though:
* The attributes are listed directly in the message instead of being inside
the Get Attributes Response Info after the unsupported attribute ID list.
* The Get Attributes Response Info can be at any position in the
attribute list, and it only contains the unsupported attribute ID list.
As a result, parsing is currently split into 3 main parts or functions:
* Parsing regular (per spec) Get Attributes Response Info attr and get a
pointer to the list of attributes.
* A function that parses the list of attributes, called directly in case
of nanoBTS, and called by the former parser of Get Attributes Response
Info for regular (per spec) OML endpoints.
* A function to parse the unsupported attribute ID list, also used in the
first function to get a pointer to the list of attributes.
Related: OS#3624
Change-Id: I52e9f177c14fec1ec3f5c4ddb244594409008357
---
M src/osmo-bsc/abis_nm.c
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Neels Hofmeyr: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/abis_nm.c b/src/osmo-bsc/abis_nm.c
index 76fba59..005c417 100644
--- a/src/osmo-bsc/abis_nm.c
+++ b/src/osmo-bsc/abis_nm.c
@@ -569,7 +569,8 @@
/* nanoBTS doesn't send Get Attribute Response Info, uses its own
format */
if (bts->type != GSM_BTS_TYPE_NANOBTS)
return parse_attr_resp_info(bts, trx, foh, &tp);
- return 0;
+ else
+ return parse_attr_resp_info_attr(bts, trx, foh, &tp);
}
/* 3GPP TS 52.021 ยง6.2.5 */
--
To view, visit https://gerrit.osmocom.org/11681
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I52e9f177c14fec1ec3f5c4ddb244594409008357
Gerrit-Change-Number: 11681
Gerrit-PatchSet: 4
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
