Stefan Sperling has submitted this change and it was merged. (
https://gerrit.osmocom.org/11729 )
Change subject: fix bogus assertion in encode_comp_field()
......................................................................
fix bogus assertion in encode_comp_field()
Fix an obvious logic bug in an assertion in encode_comp_field().
Found by: Neels
Change-Id: If6f3598cd6da4643ff2214e21c0d21f6eff0eb67
---
M src/gprs/gprs_sndcp_xid.c
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins Builder: Verified
Pau Espin Pedrol: Looks good to me, approved
diff --git a/src/gprs/gprs_sndcp_xid.c b/src/gprs/gprs_sndcp_xid.c
index 8f844b5..09e21f5 100644
--- a/src/gprs/gprs_sndcp_xid.c
+++ b/src/gprs/gprs_sndcp_xid.c
@@ -443,7 +443,7 @@
OSMO_ASSERT(comp_field->entity <= 0x1f);
/* Check if the algorithm number is within bounds */
- OSMO_ASSERT(comp_field->algo >= 0 || comp_field->algo <= 0x1f);
+ OSMO_ASSERT(comp_field->algo >= 0 && comp_field->algo <= 0x1f);
/* Zero out buffer */
memset(dst, 0, dst_maxlen);
--
To view, visit https://gerrit.osmocom.org/11729
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If6f3598cd6da4643ff2214e21c0d21f6eff0eb67
Gerrit-Change-Number: 11729
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Sperling <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
