Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11734 )
Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho ...................................................................... Patch Set 1: Code-Review+1 (4 comments) patch looks good, but only +1 to wait for passing the complete gsm0808_cell_id in params, as noted in the other patch, 11728 https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c File src/osmo-bsc/handover_fsm.c: https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c@678 PS1, Line 678: struct gsm0808_handover_performed ho_perf_params; "perf" to me reads as "performance test" :P ... whatever https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c@688 PS1, Line 688: cell = cgi_for_msc(conn->sccp.msc, conn_get_bts(conn)); (cgi_for_msc is a weird name, my fault; note to self to rename it) https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c@791 PS1, Line 791: if (result == HO_RESULT_OK && (ho->scope & HO_INTRA_CELL || ho->scope & HO_INTRA_BSC)) && (ho->scope & (HO_INTRA_CELL | HO_INTRA_BSC)) ... the more I look at it the more I believe using a bit field instead of a plain enum was a mistake. note to self to tweak that. https://gerrit.osmocom.org/#/c/11734/1/tests/handover/handover_test.c File tests/handover/handover_test.c: https://gerrit.osmocom.org/#/c/11734/1/tests/handover/handover_test.c@223 PS1, Line 223: fake_msc_data.network = &fake_bsc_gsmnet; > Why is this needed? we're in a test; and probably something dereferences a struct msc_data->network that isn't critical for the test, so this avoids a segfault. -- To view, visit https://gerrit.osmocom.org/11734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26e5807280e0f75a423b3b04f8e3c698c82a351 Gerrit-Change-Number: 11734 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 12 Nov 2018 17:14:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
