dexter has posted comments on this change. ( https://gerrit.osmocom.org/11734 )
Change subject: handover_fsm: send HANDOVER PERFORMED msg on internal ho ...................................................................... Patch Set 1: (3 comments) > (1 comment) See 3GPP TS 48.008, 3.2.1.25. There it says "This message is sent from the BSS to the MSC in order to indicate that the BSS has performed an internal handover." I think this may also be related to location based services / tracking... https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c File src/osmo-bsc/handover_fsm.c: https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c@678 PS1, Line 678: struct gsm0808_handover_performed ho_perf_params; > "perf" to me reads as "performance test" :P ... […] Done https://gerrit.osmocom.org/#/c/11734/1/src/osmo-bsc/handover_fsm.c@688 PS1, Line 688: cell = cgi_for_msc(conn->sccp.msc, conn_get_bts(conn)); > (cgi_for_msc is a weird name, my fault; note to self to rename it) We should do this in a separate patch https://gerrit.osmocom.org/#/c/11734/1/tests/handover/handover_test.c File tests/handover/handover_test.c: https://gerrit.osmocom.org/#/c/11734/1/tests/handover/handover_test.c@223 PS1, Line 223: fake_msc_data.network = &fake_bsc_gsmnet; > Why is this needed? This is now needed since the changes in this patch access fields from the network member. (I could check in the code, but you criticized it last time and I think you were right with that.) -- To view, visit https://gerrit.osmocom.org/11734 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If26e5807280e0f75a423b3b04f8e3c698c82a351 Gerrit-Change-Number: 11734 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 13 Nov 2018 12:36:36 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
