Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11701 )
Change subject: BSC_ConnectionHandler: make VTY interface available ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11701/3/msc/BSC_ConnectionHandler.ttcn File msc/BSC_ConnectionHandler.ttcn: https://gerrit.osmocom.org/#/c/11701/3/msc/BSC_ConnectionHandler.ttcn@143 PS3, Line 143: if (not g_vty_initialized) { the f_init_handler() function should always be called only once per testcase, no need for this g_vty_initialized here. The remainig other code also doesn't support calling this function multiple times during one testcase. -- To view, visit https://gerrit.osmocom.org/11701 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I684f0a3a435924d81bc5a793cb7b43a3ab9ef842 Gerrit-Change-Number: 11701 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Tue, 13 Nov 2018 15:06:17 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
