Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11789 )
Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc ...................................................................... Patch Set 1: Code-Review-1 Sorry, but I don't think it makes sense to introduce a new symbol. Why not to introduce something like: GSM_BAND_NONE or GSM_BAND_INVAL (0x00)? Moreover, you're changing the logic of old gsm_arfcn2band() anyway... -- To view, visit https://gerrit.osmocom.org/11789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I780d452dcebce385469e32ef2fd844df6033393a Gerrit-Change-Number: 11789 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 16 Nov 2018 14:37:36 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
