Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11789 )
Change subject: gsm: Deprecate buggy gsm_arfcn2band API and introduce gsm_arfcn2band_rc ...................................................................... Patch Set 1: Hi, > I could change the commit to name the new API > "gsm_arfcn2band_validate", or actually use > "osmo_gsm_arfcn2band". A possible way to go is to introduce the new osmo_gsm_arfcn2band(), introduce GSM_BAND_INVAL = 0x00, and return GSM_BAND_INVAL for 'out of band' values from there. The old gsm_arfcn2band() could then just call osmo_gsm_arfcn2band(), and replace GSM_BAND_INVAL by GSM_BAND_1800. And of course, it would be marked as deprecated. What do you think? -- To view, visit https://gerrit.osmocom.org/11789 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I780d452dcebce385469e32ef2fd844df6033393a Gerrit-Change-Number: 11789 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Mon, 19 Nov 2018 16:51:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
