Max has posted comments on this change. ( https://gerrit.osmocom.org/11690 )
Change subject: MSC_Tests: remove unused control interface ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11690/4/msc/MSC_Tests.ttcn File msc/MSC_Tests.ttcn: https://gerrit.osmocom.org/#/c/11690/4/msc/MSC_Tests.ttcn@a20 PS4, Line 20: You remove those 2 here and introduce them in next patch. Why not simply leaving it as is and only remove init function below? -- To view, visit https://gerrit.osmocom.org/11690 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I204b2e96057d13342f4bd4fdaf08fb7b88b6b11d Gerrit-Change-Number: 11690 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Mon, 19 Nov 2018 16:00:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
