osmith has posted comments on this change. ( https://gerrit.osmocom.org/11806 )
Change subject: cosmetic: update usage of OSMO_GSM_MANUALS_DIR ...................................................................... Patch Set 2: > You probably want to move this as a fixup of another commit, or at least > before patch 15/16 which will take some time to gt merged. Will do. > I kind of imagined that I just place osmo-gsm-manuals.git next to the other > osmo-* clones, and they look it up from there, no need to 'make install' or > use pkgconfig or anything? > > I mean ../osmo-gsm-manuals/ by default, and reconfigurable by > --with-osmo-gsm-manuals=~/ogm. > > Maybe if --with-osmo-gsm-manuals=path is passed use that, if not try > pkgconfig first, if that fails try ../osmo-gsm-manuals? Well, with the patches I'm submitting here, the workflow would be: $ cd osmo-gsm-manuals $ autoreconf -fi $ ./configure $ make install $ cd ../osmo-msc $ autoreconf -fi $ ./configure --enable-manuals $ make or instead of make, if you just want the manuals, run in the osmo-msc (or other project) dir: $ make -C docs/manuals Reasons are explained in this commit message: https://gerrit.osmocom.org/#/c/osmo-gsm-manuals/+/11797/ I did *not* add a fallback to "../osmo-gsm-manuals" for OSMO_GSM_MANUALS_DIR or other means to override it, though that should be possible to add with some configure.ac magic. Would you prefer if I added it? -- To view, visit https://gerrit.osmocom.org/11806 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64cfffb5104edcf7a20f41aeb5bf8ee6988b57c4 Gerrit-Change-Number: 11806 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Neels Hofmeyr <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 20 Nov 2018 14:49:33 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
