osmith has posted comments on this change. ( https://gerrit.osmocom.org/11803 )
Change subject: Makefile.*.inc: adjust to out-of-tree building ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11803/3/build/Makefile.asciidoc.inc File build/Makefile.asciidoc.inc: https://gerrit.osmocom.org/#/c/11803/3/build/Makefile.asciidoc.inc@63 PS3, Line 63: # $(notdir) is like basename from coreutils, and $PWD is the $(builddir). > where is $PWD used here? This should be an explanation for $(builddir), just like $(notdir) is explained before (that's my understanding of it anyway, the line was suggested by Neels). I'll switch it around to $(builddir) is $PWD, then the explanation is on the right side just like with $(notdir) and $< before. -- To view, visit https://gerrit.osmocom.org/11803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6b212a6518f0fc29fae610a37ae6c533189278d Gerrit-Change-Number: 11803 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 12:26:37 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
