Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11803 )
Change subject: Makefile.*.inc: adjust to out-of-tree building ...................................................................... Patch Set 3: Code-Review+2 (2 comments) https://gerrit.osmocom.org/#/c/11803/3/build/Makefile.asciidoc.inc File build/Makefile.asciidoc.inc: https://gerrit.osmocom.org/#/c/11803/3/build/Makefile.asciidoc.inc@63 PS3, Line 63: # $(notdir) is like basename from coreutils, and $PWD is the $(builddir). > This should be an explanation for $(builddir), just like $(notdir) is > explained before (that's my un […] or write out "current directory" or "we are in"... (but I obviously think it's ok like this too) https://gerrit.osmocom.org/#/c/11803/3/build/Makefile.asciidoc.inc@69 PS3, Line 69: # in $(OSMO_GSM_MANUALS_DIR). very nice, warm and fuzzy -- To view, visit https://gerrit.osmocom.org/11803 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6b212a6518f0fc29fae610a37ae6c533189278d Gerrit-Change-Number: 11803 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Wed, 21 Nov 2018 12:48:21 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
