Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 )
Change subject: add database schema versioning to the HLR database ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/#/c/11898/1/sql/hlr.sql File sql/hlr.sql: https://gerrit.osmocom.org/#/c/11898/1/sql/hlr.sql@48 PS1, Line 48: -- last_lu_seen TIMESTAMP default NULL > Ah I see, so the CREATE TABLE stuff is called everytime during db_bootstrap, > and it just succeeds ev […] Yes, that's the way it has been implemented from the beginning. I'd rather keep this as-is. I don't see how we could tell apart a fresh db from an existing one after sqlite3_open() on a non-racy way. This seems to be impossible without running into TOCTOU issues (time of check vs time of use). -- To view, visit https://gerrit.osmocom.org/11898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b Gerrit-Change-Number: 11898 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Fri, 23 Nov 2018 11:41:43 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
