Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/11898 )
Change subject: add database schema versioning to the HLR database ...................................................................... Patch Set 4: > Patch Set 4: Code-Review-1 > Also, I think an upgrade should be opt-in. Add a --db-allow-upgrade cmdline > option and otherwise error out hinting at that option if an upgrade would be > required. What is the benefit? The user will have to upgrade the DB in any case. If the DB is not upgraded, then osmo-hlr won't even start because even just preparing any SQL statements which perform a select from non-existent columns will fail with an error. -- To view, visit https://gerrit.osmocom.org/11898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aeaa9a404b622657cbc7138106f38aa6ad8d01b Gerrit-Change-Number: 11898 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 27 Nov 2018 14:41:28 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
