Pau Espin Pedrol has posted comments on this change. ( 
https://gerrit.osmocom.org/11904 )

Change subject: rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/11904/1/src/common/rsl.c
File src/common/rsl.c:

https://gerrit.osmocom.org/#/c/11904/1/src/common/rsl.c@2203
PS1, Line 2203: LOGL_NOTICE
> Unrelated. […]
I think it's related to the patch, in the sense it modifies the same code path 
and scenario. Since we remove the NACK, we are really not taking this as an 
error because it is known that actually it is (de)activating the channel 
anyway, so it's not an error.



--
To view, visit https://gerrit.osmocom.org/11904
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c65da6b6b7094f32187d3b083153a87c3219fd
Gerrit-Change-Number: 11904
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-CC: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Fri, 23 Nov 2018 19:00:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to