Neels Hofmeyr has posted comments on this change. ( 
https://gerrit.osmocom.org/11904 )

Change subject: rsl: Avoid sending ipa PDCH DEACT NACK followed by ACK
......................................................................


Patch Set 1:

(1 comment)

(posting forgotten Draft comments, may be hoplessly outdated now. Easiest to 
get rid of them is to just "Reply", so bear with me, thx)

https://gerrit.osmocom.org/#/c/11904/1//COMMIT_MSG
Commit Message:

https://gerrit.osmocom.org/#/c/11904/1//COMMIT_MSG@15
PS1, Line 15: TCH/F).
one thing I don't understand yet in the overall failure cause: osmo-bsc must be 
sending a PDCH DE/ACT while the ts is still active, right?

Oh, that was the osmo-bts-trx patch where we now send an ACK only *after* it 
really went officially inactive?

So it's not an osmo-bsc bug?



--
To view, visit https://gerrit.osmocom.org/11904
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I91c65da6b6b7094f32187d3b083153a87c3219fd
Gerrit-Change-Number: 11904
Gerrit-PatchSet: 1
Gerrit-Owner: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com>
Gerrit-CC: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Dec 2018 12:06:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to