Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11654 )
Change subject: paging: Add VTY options to calculate T3113 timeout dynamically ...................................................................... Patch Set 3: (1 comment) https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/bsc_vty.c File src/osmo-bsc/bsc_vty.c: https://gerrit.osmocom.org/#/c/11654/3/src/osmo-bsc/bsc_vty.c@3916 PS3, Line 3916: "Calculate T3113 dynamically based on channel config and load\n" > Point 1 is, we often have #defines to re-use the exact same string again, > because only one doc strin […] Following your logic, it's clear that in "foo bar?", ? applies only to last parameter, and not to whole sentence, so of course having "no" in front of it means the opposite, like in human language. Another topic is whether it would make sense to print whole parameter list description up to the point where "?" is used, instead of only printing the description of last parameter. That way you'd get "Not bar-description". But it's a separate topic. -- To view, visit https://gerrit.osmocom.org/11654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f Gerrit-Change-Number: 11654 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Tue, 27 Nov 2018 12:06:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
