Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11654 )
Change subject: paging: Add VTY options to calculate T3113 timeout dynamically ...................................................................... Patch Set 6: Code-Review+1 i'm not sure whether the dynamic semantics are correct. I would +2 if you kept the previous behavior as default. But since you're using the new code by default, someone needs to approve because I don't fully know this stuff. Why are you changing the default behavior though? Another item on the list of things I don't like. -- To view, visit https://gerrit.osmocom.org/11654 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4fb2969b690151415038631fb6ad059aa6835c7f Gerrit-Change-Number: 11654 Gerrit-PatchSet: 6 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Wed, 05 Dec 2018 15:52:50 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
