Vadim Yanitskiy has uploaded this change for review. ( 
https://gerrit.osmocom.org/11984


Change subject: library/GSUP_Types.ttcn: fix missing session state IE in 
PROC_SS_ERR
......................................................................

library/GSUP_Types.ttcn: fix missing session state IE in PROC_SS_ERR

Change-Id: I44070396ce7119eab4608d9f9fb090bb223dfaa2
---
M hlr/HLR_Tests.ttcn
M library/GSUP_Types.ttcn
2 files changed, 8 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks 
refs/changes/84/11984/1

diff --git a/hlr/HLR_Tests.ttcn b/hlr/HLR_Tests.ttcn
index f7902be..e32fa68 100644
--- a/hlr/HLR_Tests.ttcn
+++ b/hlr/HLR_Tests.ttcn
@@ -476,16 +476,16 @@
        GSUP.send(valueof(ts_GSUP_PROC_SS_REQ(imsi, sid, state, ss)));
        T.start;
        alt {
-       [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, exp_err_cause)) 
-> value ret {
+       [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, 
exp_err_cause)) -> value ret {
                setverdict(pass);
                }
-       [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?)) -> value ret 
{
+       [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value 
ret {
                setverdict(fail, "Unexpected PROC_SS ERROR Cause");
                }
        [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, ?, ?)) -> value 
ret {
                setverdict(fail, "Unexpected PROC_SS.res for unknown IMSI");
                }
-       [not exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?)) -> value 
ret {
+       [not exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> 
value ret {
                setverdict(fail, "Unexpected PROC_SS ERROR");
                }
        [not exp_fail] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, ?, ?)) -> 
value ret {
@@ -511,7 +511,7 @@
        }
        T.start;
        alt {
-       [] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?)) -> value ret {
+       [] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, ?)) -> value ret {
                setverdict(fail, "Unexpected PROC_SS ERROR Cause");
                }
        [not exp_ss] GSUP.receive(tr_GSUP_PROC_SS_RES(imsi, sid, state, omit)) 
-> value ret {
diff --git a/library/GSUP_Types.ttcn b/library/GSUP_Types.ttcn
index 7680815..cadc6d8 100644
--- a/library/GSUP_Types.ttcn
+++ b/library/GSUP_Types.ttcn
@@ -692,24 +692,28 @@
 template (value) GSUP_PDU ts_GSUP_PROC_SS_ERR(
        hexstring imsi,
        OCT4 sid,
+       GSUP_SessionState state,
        integer cause
 ) := ts_GSUP(
        OSMO_GSUP_MSGT_PROC_SS_ERROR,
        {
                valueof(ts_GSUP_IE_IMSI(imsi)),
                valueof(ts_GSUP_IE_SessionId(sid)),
+               valueof(ts_GSUP_IE_SessionState(state)),
                valueof(ts_GSUP_IE_Cause(cause))
        }
 );
 template GSUP_PDU tr_GSUP_PROC_SS_ERR(
        template hexstring imsi,
        template OCT4 sid := ?,
+       template GSUP_SessionState state := ?,
        template integer cause := ?
 ) := tr_GSUP(
        OSMO_GSUP_MSGT_PROC_SS_ERROR,
        {
                tr_GSUP_IE_IMSI(imsi),
                tr_GSUP_IE_SessionId(sid),
+               tr_GSUP_IE_SessionState(state),
                tr_GSUP_IE_Cause(cause)
        }
 );

--
To view, visit https://gerrit.osmocom.org/11984
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I44070396ce7119eab4608d9f9fb090bb223dfaa2
Gerrit-Change-Number: 11984
Gerrit-PatchSet: 1
Gerrit-Owner: Vadim Yanitskiy <[email protected]>

Reply via email to