Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11984 )
Change subject: library/GSUP_Types.ttcn: fix missing session state IE in PROC_SS_ERR ...................................................................... Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/11984/1/hlr/HLR_Tests.ttcn File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/#/c/11984/1/hlr/HLR_Tests.ttcn@479 PS1, Line 479: [exp_fail] GSUP.receive(tr_GSUP_PROC_SS_ERR(imsi, sid, ?, exp_err_cause)) -> value ret { IIUC now HLR_Tests requires presence of the added IE. (because ? expects something, * would be "don't care") This change should be mentioned in the commit log -- To view, visit https://gerrit.osmocom.org/11984 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I44070396ce7119eab4608d9f9fb090bb223dfaa2 Gerrit-Change-Number: 11984 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 13:32:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
