Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11980 )
Change subject: bsc: Add define for ts_as_pchan_for_each_lchan with ts->pchan_on_init ...................................................................... Patch Set 2: Code-Review+1 (5 comments) https://gerrit.osmocom.org/#/c/11980/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11980/2//COMMIT_MSG@10 PS2, Line 10: to document its (intrincate) logic around it and its possible uses. intricate https://gerrit.osmocom.org/#/c/11980/2/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/11980/2/include/osmocom/bsc/gsm_data.h@482 PS2, Line 482: * on PCHAN \ref ts (dynamic) configuration. (is that doxygen notation in a non-doxygen comment in a project that doesn't generate doxygen api docs?) Can you rephrase "based on PCHAN ts (dynamic) config"? https://gerrit.osmocom.org/#/c/11980/2/include/osmocom/bsc/gsm_data.h@488 PS2, Line 488: * of \ref lchan. Maybe rather... "Iterate all lchan instances set up by this timeslot type, including those lchans currently disabled (e.g. due to dynamic timeslot in switchover). Compare ts_for_each_lchan(), which iterates only the enabled lchans." https://gerrit.osmocom.org/#/c/11980/2/include/osmocom/bsc/gsm_data.h@490 PS2, Line 490: * configuration PDCH (no lchans) to TCH_F (1 lchan), where pchan_is is still To name all possibilities, you'd have to name both dyn TS kinds, all TCH targets, as well as TCH/F_TCH/H_PDCH in unused mode when GPRS is disabled, or ones switching between TCH/F and TCH/H, ... So maybe rather start with "For example,..." https://gerrit.osmocom.org/#/c/11980/2/include/osmocom/bsc/gsm_data.h@494 PS2, Line 494: #define ts_for_each_lchan_slot(lchan, ts) ts_as_pchan_for_each_lchan(lchan, ts, (ts)->pchan_on_init) IMHO "slot" is a general term not describing what sets this macro apart from ts_for_each_lchan(). Can't think of a better name either... ts_for_each_potential_lchan()?? -- To view, visit https://gerrit.osmocom.org/11980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1d4bdbfca6b9719f54ee609b6bfadf7f3a4bb43 Gerrit-Change-Number: 11980 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 18:48:02 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
