Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11980 )
Change subject: bsc: Add define for ts_as_pchan_for_each_lchan with ts->pchan_on_init ...................................................................... Patch Set 3: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/11980/3/include/osmocom/bsc/gsm_data.h File include/osmocom/bsc/gsm_data.h: https://gerrit.osmocom.org/#/c/11980/3/include/osmocom/bsc/gsm_data.h@483 PS3, Line 483: * Iterate all lchan instances set up by this \ref ts type, including those again this is not a doxygen comment (no '/*!' in the start) but still you're using \ref. I'd just drop the doxygen formatting altogether. But doesn't matter much either. -- To view, visit https://gerrit.osmocom.org/11980 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1d4bdbfca6b9719f54ee609b6bfadf7f3a4bb43 Gerrit-Change-Number: 11980 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Assignee: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 17:00:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
