Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11981 )
Change subject: bsc: timelost_fsm: Remove unneeded set of out variable on failure ...................................................................... Patch Set 2: (1 comment) I'd rather omit this patch, because... https://gerrit.osmocom.org/#/c/11981/2/src/osmo-bsc/timeslot_fsm.c File src/osmo-bsc/timeslot_fsm.c: https://gerrit.osmocom.org/#/c/11981/2/src/osmo-bsc/timeslot_fsm.c@867 PS2, Line 867: return false; my idea here was to avoid leaving a value in an uninitialized state. I always try to initialize out-arguments in all code paths, usually with NULL, but here if no lchan is waiting it makes sense to remain in the current pchan_is. -- To view, visit https://gerrit.osmocom.org/11981 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib8f9b7e1f584dee885d6823dc043682577572bd8 Gerrit-Change-Number: 11981 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 29 Nov 2018 19:02:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
