Pau Espin Pedrol has submitted this change and it was merged. (
https://gerrit.osmocom.org/11981 )
Change subject: bsc: timelost_fsm: Remove unneeded set of out variable on
failure
......................................................................
bsc: timelost_fsm: Remove unneeded set of out variable on failure
Documentation of the function explicitly states that the out
target_pchan param returns the "PCHAN waited for". If we return false,
then no PCHAN is being waited for. The 2 callers of this function only
use this out param if function returns true, so let's simplify the code.
Change-Id: Ib8f9b7e1f584dee885d6823dc043682577572bd8
---
M src/osmo-bsc/timeslot_fsm.c
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Harald Welte: Looks good to me, approved
Neels Hofmeyr: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c
index 113ec36..1450491 100644
--- a/src/osmo-bsc/timeslot_fsm.c
+++ b/src/osmo-bsc/timeslot_fsm.c
@@ -864,9 +864,6 @@
return true;
}
}
-
- if (target_pchan)
- *target_pchan = ts->pchan_is;
return false;
}
--
To view, visit https://gerrit.osmocom.org/11981
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8f9b7e1f584dee885d6823dc043682577572bd8
Gerrit-Change-Number: 11981
Gerrit-PatchSet: 5
Gerrit-Owner: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
