Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12039 )
Change subject: rename gsm_encr to geran_encr, it is only applicable on GERAN ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12039/2/include/osmocom/msc/common_cs.h File include/osmocom/msc/common_cs.h: https://gerrit.osmocom.org/#/c/12039/2/include/osmocom/msc/common_cs.h@12 PS2, Line 12: geran_encr Maybe we could even move this definition into the 'gsm_subscriber_connection' struct definition? (unrelated, just an idea) -- To view, visit https://gerrit.osmocom.org/12039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc7ca9da1aa13ae16f5db2cb1024676cbc770820 Gerrit-Change-Number: 12039 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 30 Nov 2018 10:01:08 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
