Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12039 )
Change subject: rename gsm_encr to geran_encr, it is only applicable on GERAN ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12039/3/src/libmsc/gsm_04_08.c File src/libmsc/gsm_04_08.c: https://gerrit.osmocom.org/#/c/12039/3/src/libmsc/gsm_04_08.c@1666 PS3, Line 1666: conn->geran_encr = (struct geran_encr){}; This looks cleaner to me: conn->geran_encr = {0}; -- To view, visit https://gerrit.osmocom.org/12039 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc7ca9da1aa13ae16f5db2cb1024676cbc770820 Gerrit-Change-Number: 12039 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 30 Nov 2018 16:32:14 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
