Change in libosmocore[master]: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED

[Max]

Max has posted comments on this change. ( https://gerrit.osmocom.org/11728 )

Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.osmocom.org/#/c/11728/4/src/gsm/gsm0808.c
File src/gsm/gsm0808.c:

https://gerrit.osmocom.org/#/c/11728/4/src/gsm/gsm0808.c@913
PS4, Line 913:  msgb_tlv_put(msg, GSM0808_IE_CAUSE, params->cause & 0x80 ? 2 : 
1, (const uint8_t *)&params->cause);
> I see, we should add a helper function that adds a cause. […]
It's already implemented - see gsm0808_create_cipher_reject_ext()



--
To view, visit https://gerrit.osmocom.org/11728
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I825106858bd89afc9837811b8fed2e8accc82441
Gerrit-Change-Number: 11728
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <msur...@sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-CC: Pau Espin Pedrol <pes...@sysmocom.de>
Gerrit-Comment-Date: Fri, 30 Nov 2018 10:36:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No