Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11728 )
Change subject: gsm0808: add message generator for BSSMAP HANDOVER PERFORMED ...................................................................... Patch Set 4: Code-Review+1 (3 comments) Another pass, but would also be ok with me to merge as-is. https://gerrit.osmocom.org/#/c/11728/4/include/osmocom/gsm/gsm0808.h File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/#/c/11728/4/include/osmocom/gsm/gsm0808.h@174 PS4, Line 174: struct gsm0808_cell_id cell; (in osmo-bsc it is usually called "cell_id") https://gerrit.osmocom.org/#/c/11728/4/include/osmocom/gsm/gsm0808.h@186 PS4, Line 186: struct gsm0808_speech_codec speech_codec_chosen; in above structs we have a 'bool more_items' to allow backwards compatible extensions to this struct. Are there items in this message we so far ignore? If yes such a bool might help someone in the future... https://gerrit.osmocom.org/#/c/11728/4/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/11728/4/src/gsm/gsm0808.c@926 PS4, Line 926: /* Sspeech Version (chosen) 3.2.2.51 */ Chosen: Parseltounge (scnr, I mean the "Ss" typo) -- To view, visit https://gerrit.osmocom.org/11728 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I825106858bd89afc9837811b8fed2e8accc82441 Gerrit-Change-Number: 11728 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 27 Nov 2018 00:48:06 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
