Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/11826 )
Change subject: LCLS: add gsm0808_create_ass_ext() ...................................................................... Patch Set 16: Code-Review-1 (4 comments) https://gerrit.osmocom.org/#/c/11826/10/include/osmocom/gsm/gsm0808.h File include/osmocom/gsm/gsm0808.h: https://gerrit.osmocom.org/#/c/11826/10/include/osmocom/gsm/gsm0808.h@67 PS10, Line 67: struct msgb *gsm0808_create_ass_ext(const struct gsm0808_channel_type *ct, > Why? So far both ...2() and ..._ext() are widely used throughout the code. […] "ext" refers to "extended", while this is not something that the spec calls "extended" in any way. This is just a newer version of our API function, and for that the convention is (or should be) adding numbers. What if at some point some more IEs should be added, or some bug gets fixed? what do we call the next API function then, create_ass_ext_ext()? Use '2'. https://gerrit.osmocom.org/#/c/11826/16/src/gsm/gsm0808.c File src/gsm/gsm0808.c: https://gerrit.osmocom.org/#/c/11826/16/src/gsm/gsm0808.c@424 PS16, Line 424: /*! Create BSSMAP Assignment Request message, 3GPP TS 48.008 §3.2.1.1 especially if adding more comment, the initial summary line must end in a '.' https://gerrit.osmocom.org/#/c/11826/16/src/gsm/gsm0808.c@425 PS16, Line 425: This is identical to gsm0808_create_ass(), but adds KC and LCLS IEs. lacks a '*' https://gerrit.osmocom.org/#/c/11826/16/src/gsm/gsm0808.c@512 PS16, Line 512: /*! Create BSSMAP Assignment Request message, 3GPP TS 48.008 §3.2.1.1 . -- To view, visit https://gerrit.osmocom.org/11826 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id89765df3f8c12f55f73f1d7a9d90c8883eb3bba Gerrit-Change-Number: 11826 Gerrit-PatchSet: 16 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Fri, 30 Nov 2018 15:54:22 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
