Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12044 )
Change subject: gsm0808: add encoder for cause codes and use it ...................................................................... Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12044/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12044/1//COMMIT_MSG@13 PS1, Line 13: extended up to two bytes. Lets implement the encoding over and over > I guess you menat: "Instead of implementing the encoding over and over and > again, let's rather have […] this wording should be fixed. the remainder of the patch is fine for me. -- To view, visit https://gerrit.osmocom.org/12044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71d58fad89502a43532f60717ca022c15c73f8bb Gerrit-Change-Number: 12044 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 03 Dec 2018 13:57:57 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
