Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12044 )
Change subject: gsm0808: add encoder for cause codes and use it ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12044/3/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: https://gerrit.osmocom.org/#/c/12044/3/src/gsm/gsm0808_utils.c@68 PS3, Line 68: osmo_store16be(cause, msg->tail); logical order of l68 and l69 looks wrong to me. BTW, I think you can rmove both and simply use msgb_put_u16(msg, cause); -- To view, visit https://gerrit.osmocom.org/12044 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71d58fad89502a43532f60717ca022c15c73f8bb Gerrit-Change-Number: 12044 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 11:56:07 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
