Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers ...................................................................... Patch Set 5: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12017/5/src/msgb.c File src/msgb.c: https://gerrit.osmocom.org/#/c/12017/5/src/msgb.c@198 PS5, Line 198: printf I think we should avoid using printf() in libosmocore. Other parts of this unit are using 'LOGP(DLGLOBAL, ...)'. -- To view, visit https://gerrit.osmocom.org/12017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5 Gerrit-Change-Number: 12017 Gerrit-PatchSet: 5 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Mon, 03 Dec 2018 14:48:40 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
