Max has posted comments on this change. ( https://gerrit.osmocom.org/12017 )
Change subject: msgb: add test helpers ...................................................................... Patch Set 11: > one slight problem with LOGP could be that in regression tests, we often only > check stdout. Actually as long as we check the result of test helper and abort() it should be fine. We can always inspect the logs manually. -- To view, visit https://gerrit.osmocom.org/12017 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3bc95f2f5ab6e3f4b502647fb3e0aaaf1f7c4cf5 Gerrit-Change-Number: 12017 Gerrit-PatchSet: 11 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 10:49:44 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
