Max has posted comments on this change. ( https://gerrit.osmocom.org/12094 )

Change subject: Add osmo_init_logging_std*()
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.osmocom.org/#/c/12094/1/tests/logging/logging_vty_test.c
File tests/logging/logging_vty_test.c:

https://gerrit.osmocom.org/#/c/12094/1/tests/logging/logging_vty_test.c@245
PS1, Line 245:  if (osmo_init_logging_stderr(root_ctx, &log_info) == 0) {
> AFAIU from application. […]
That's exactly what we test in here: we fail this test if 
osmo_init_logging_stderr() is not failing as it should.



--
To view, visit https://gerrit.osmocom.org/12094
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe8dc4a41aba4e4509540266e229700e8ec083c
Gerrit-Change-Number: 12094
Gerrit-PatchSet: 1
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-CC: Pau Espin Pedrol <[email protected]>
Gerrit-Comment-Date: Tue, 04 Dec 2018 12:07:51 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to