Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12094 )
Change subject: Add osmo_init_logging_std*() ...................................................................... Patch Set 2: > > Yes, but it would fail to if you used osmo_init_logging_stdout > here. > > Sure, right now those are mutually exclusive. > > > So that means you cannot configure stderr and stdout at the same > time > > That's correct. > > > Please provide me with information if I'm not understanding it. > > It's intended for tests which do not use vty and do not need to log > to stderr and stdout at the same time - see commit message of this > and previous patch. If you only care about libosmocore logging system output, why not simply checking output template file against stderr? or run test with 2>&1 I so far think this adds extra complexity to the logging system for no good reason, because anyway you cannot configure both stderr and stdout separately. -- To view, visit https://gerrit.osmocom.org/12094 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0fe8dc4a41aba4e4509540266e229700e8ec083c Gerrit-Change-Number: 12094 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Tue, 04 Dec 2018 12:45:19 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
