Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12132 )
Change subject: jenkins.sh: run "make distcheck" ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12132/2/contrib/jenkins.sh File contrib/jenkins.sh: https://gerrit.osmocom.org/#/c/12132/2/contrib/jenkins.sh@102 PS2, Line 102: DISTCHECK_CONFIGURE_FLAGS="--enable-sanitize $CONFIG" $MAKE distcheck \ Fine, but we should enabl all flags we enable in normal configure, otherwise we don't check all features can be built during distcheck. -- To view, visit https://gerrit.osmocom.org/12132 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d3fa0fe12e13ca13d3330158425718e5c34d00d Gerrit-Change-Number: 12132 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-CC: Neels Hofmeyr <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 05 Dec 2018 15:18:35 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
