Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12120 )
Change subject: Add CTRL log category ...................................................................... Patch Set 2: Code-Review-1 > > Actually I would argue to log to DLCTRL in this case. Either you > > want to see logging of all CTRL related messages at a certain > lvel, > > or not... > > I don't really understand this comment. libosmocore IPA CTRL > interface has nothing to do with CTRL socket of the TRX, so for > sure I don't want them to be the same category. Don't call it CTRL if it's not CTRL. Please call it TRXCTRL or something else unambiguous. -- To view, visit https://gerrit.osmocom.org/12120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98ec5e416272783ad3fbadf70478a4e48ae64983 Gerrit-Change-Number: 12120 Gerrit-PatchSet: 2 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Wed, 05 Dec 2018 19:43:11 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
