Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12120 )
Change subject: Add CTRL log category ...................................................................... Patch Set 3: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12120/3/CommonLibs/debug.c File CommonLibs/debug.c: https://gerrit.osmocom.org/#/c/12120/3/CommonLibs/debug.c@14 PS3, Line 14: .name = "DCTRL", enum value and 'name' should match. (there also is DLCTRL about the osmo ctrl interface. You're not referring to that one, right.) -- To view, visit https://gerrit.osmocom.org/12120 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98ec5e416272783ad3fbadf70478a4e48ae64983 Gerrit-Change-Number: 12120 Gerrit-PatchSet: 3 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 19:10:48 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
