Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12153 )
Change subject: add osmo_bsc2str() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12153/2/src/utils.c File src/utils.c: https://gerrit.osmocom.org/#/c/12153/2/src/utils.c@143 PS2, Line 143: int osmo_bcd2str(char *dst, size_t dst_size, const uint8_t bcd[], int start_nibble, int end_nibble) > hmm, but snprintf() returns int, too. Sure, because it can fail parsing, not like this function apparently ;) Furthermore, you don't specify a negative error being returned in the API, so what does a negative value being returned mean? -- To view, visit https://gerrit.osmocom.org/12153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86b09d37ceef33331c1a56046a5443127d6c6be0 Gerrit-Change-Number: 12153 Gerrit-PatchSet: 2 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 15:33:26 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
