Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12153 )
Change subject: add osmo_bcd2str() ...................................................................... Patch Set 4: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/12153/4/src/utils.c File src/utils.c: https://gerrit.osmocom.org/#/c/12153/4/src/utils.c@154 PS4, Line 154: *dst = osmo_bcd2char(nibble); Hmm, I think while at it I should add optional bcd char verification. AFAICT bcd means 0-9, but osmo_bcd2char() returns [0-9A-F], so maybe some bcd out there is more than binary-coded-DECIMAL: bch? -- To view, visit https://gerrit.osmocom.org/12153 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I86b09d37ceef33331c1a56046a5443127d6c6be0 Gerrit-Change-Number: 12153 Gerrit-PatchSet: 4 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 12:18:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
