Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12121 )
Change subject: store timestamp of last location update seen from subscriber ...................................................................... Patch Set 5: Code-Review-1 (7 comments) https://gerrit.osmocom.org/#/c/12121/5//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12121/5//COMMIT_MSG@9 PS5, Line 9: Store a timestamp of the last location update seen from a subscriber Can we have full first sentence in first line, and then dropped repeated line in first description pragraph? Looks like I can foresee the next word before reading it otherwise ;) https://gerrit.osmocom.org/#/c/12121/5//COMMIT_MSG@11 PS5, Line 11: in the 'subscriber' table, in granularity of seconds. Describe what do the value mean. seconds in UTC time? https://gerrit.osmocom.org/#/c/12121/5//COMMIT_MSG@15 PS5, Line 15: human-readable formt, they may already provide value to external typo: formt https://gerrit.osmocom.org/#/c/12121/5//COMMIT_MSG@19 PS5, Line 19: 901990000000001|2018-12-04 14:17:12 I wonder why we don't store it as num of seconds since 1970. Or it's sqlite transforming it through cli app? https://gerrit.osmocom.org/#/c/12121/5/sql/hlr.sql File sql/hlr.sql: https://gerrit.osmocom.org/#/c/12121/5/sql/hlr.sql@42 PS5, Line 42: last_lu_seen TIMESTAMP default NULL I'm not able to find TIMESTAMP in sqlite documentation so far. https://www.sqlite.org/datatype3.html https://gerrit.osmocom.org/#/c/12121/5/sql/hlr.sql@75 PS5, Line 75: PRAGMA user_version = 1; this 1 together with CURRENT_SCHEMA_VERSION in code looks like a candaidate to have in configure.ac and then have a hlr.sql.in which becomes processed. But not really needed :) https://gerrit.osmocom.org/#/c/12121/5/src/db_hlr.c File src/db_hlr.c: https://gerrit.osmocom.org/#/c/12121/5/src/db_hlr.c@637 PS5, Line 637: "Cannot update LU timestamp for subscriber ID=%"PRId64": SQL error: (%d) %s\n", Be careful in general with interleavin strings and PRId64 type of strings, I recall seeing compilers failing because they don't like 2 strings to be concatenated if there's no space in between. So to avoid possible issues,always try to leave a speace in between: ...ID=%" PRId64 ": SQL... -- To view, visit https://gerrit.osmocom.org/12121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeb49d45aec18451a260a6654b8c51b8fc3bec50 Gerrit-Change-Number: 12121 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 15:54:29 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
