Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12121 )
Change subject: store timestamp of last location update seen from subscriber ...................................................................... Patch Set 5: (3 comments) https://gerrit.osmocom.org/#/c/12121/5//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12121/5//COMMIT_MSG@11 PS5, Line 11: in the 'subscriber' table, in granularity of seconds. > Describe what do the value mean. […] (imho what the value means should be in a code comment and not so much in a commit log) https://gerrit.osmocom.org/#/c/12121/5/sql/hlr.sql File sql/hlr.sql: https://gerrit.osmocom.org/#/c/12121/5/sql/hlr.sql@42 PS5, Line 42: last_lu_seen TIMESTAMP default NULL > I'm not able to find TIMESTAMP in sqlite documentation so far. > https://www.sqlite.org/datatype3. […] found https://www.sqlite.org/lang_datefunc.html but am also puzzled why there seems to be no TIMESTAMP. In https://www.sqlite.org/datatypes.html (version 2) it says "SQLite is "typeless". This means that you can store any kind of data you want in any column of any table" -- and version 2 names a TIMESTAMP type. In 3 it says "SQLite does not have a storage class set aside for storing dates and/or times. Instead, the built-in Date And Time Functions of SQLite are capable of storing dates and times as TEXT, REAL, or INTEGER values" So apparently TIMESTAMP is a shim for TEXT. https://gerrit.osmocom.org/#/c/12121/5/sql/hlr.sql@75 PS5, Line 75: PRAGMA user_version = 1; > this 1 together with CURRENT_SCHEMA_VERSION in code looks like a candaidate > to have in configure. […] also think it's nice to have a single place... ideally the other version would be derived from this file, but I guess that's too complex? Otherwise not so nice to open the unbuilt source and not be able to see the actual version? so unless some bright idea comes up we'll have it duplicated. -- To view, visit https://gerrit.osmocom.org/12121 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeb49d45aec18451a260a6654b8c51b8fc3bec50 Gerrit-Change-Number: 12121 Gerrit-PatchSet: 5 Gerrit-Owner: Stefan Sperling <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Thu, 06 Dec 2018 16:37:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
