Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12180 )
Change subject: rsl: Send PDCH ACT NACK if TCH chan is still active ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/12180/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12180/1//COMMIT_MSG@19 PS1, Line 19: rsl.c:2103 (bts=0,trx=0,ts=3,ss=0) Tx PDCH DEACT ACK > one thing I don't understand yet in the overall failure cause: is it an > osmo-bsc bug? is it sending […] no, in here I'm just showing that scenario 2 still works fine with and without this patch (BTS sends a PDCH DEACT ACK, so no need to touch that code path). https://gerrit.osmocom.org/#/c/12180/1/src/common/rsl.c File src/common/rsl.c: https://gerrit.osmocom.org/#/c/12180/1/src/common/rsl.c@2207 PS1, Line 2207: /* TCH takes preference over PDCH so allow forcing PDCH DEACT, > plz explain: if a TS is in PDCH mode, sending a DEACT is not forcing > anything. […] >From looking at BTS code, it looks like PDCH in general is expected to be >!NONE too, but I didn't go into detail since wasn't needed to fix the issue >(the scenario is quite narrow and the code was more or less already there >before I touched it). Maybe PDCH is !NONE if there's some TBF active or similar, I don't know tbh. https://gerrit.osmocom.org/#/c/12180/1/src/common/rsl.c@2208 PS1, Line 2208: * but forbid forcing PDCH ACT if lchan still active */ > (say it without the word "forcing"?) If we allowed it, we would force the BTS to drop an active channel which may be in use in order to switch it to PDCH.To me that's forcing. Otherwise it would go through another code path. -- To view, visit https://gerrit.osmocom.org/12180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d6d12aec10c801fe55012ca6e58d0bc8755b15d Gerrit-Change-Number: 12180 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Fri, 07 Dec 2018 10:26:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
