Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12180 )
Change subject: rsl: Send PDCH ACT NACK if TCH chan is still active ...................................................................... Patch Set 1: > The idea of a commit log is that the reviewer can skip all that > because you have explained it :) I think the commit description provides enough context to understand the issue and how it was added (originating commit), how to reproduce the issue (TTCN3 test, and how it behaves in commit description), and why exactly the added code behaves (there's a comment explaining the case/scenario on top of the code). Feel free to provide an explicit change in order to merge the change, or we can keep with osmo-bts misbehaving and a TTCN3 failing for a few more months for apparently no good reason. It's a 2 lines change with a TTCN3 test behind it showcasing the issue, not a complete refactor of 1000 code lines. -- To view, visit https://gerrit.osmocom.org/12180 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6d6d12aec10c801fe55012ca6e58d0bc8755b15d Gerrit-Change-Number: 12180 Gerrit-PatchSet: 1 Gerrit-Owner: Pau Espin Pedrol <[email protected]> Gerrit-Assignee: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Thu, 20 Dec 2018 00:58:12 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
