Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12199 )
Change subject: gsm29118: add generator functions for GSM29118 messages ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/12199/1/src/gsm/gsm29118.c File src/gsm/gsm29118.c: https://gerrit.osmocom.org/#/c/12199/1/src/gsm/gsm29118.c@251 PS1, Line 251: * \param[in] imsi IMSI of the subscriber. > In our case it makes sense because in the MSC we already have the data ready > as a message buffer. […] Sure but in that case it doesn't hurt for us to simply pass: "nas_msg->data, nas_msg->len" instead of nas_msg. But fine anyway. -- To view, visit https://gerrit.osmocom.org/12199 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic87f8a771b87b52215d0a7451b67794557b80b8a Gerrit-Change-Number: 12199 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: dexter <[email protected]> Gerrit-Comment-Date: Fri, 07 Dec 2018 17:39:55 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
