Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12208 )
Change subject: Revert "mobile: use VTY bind addr from config, deprecate cmd line options" ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/12208/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12208/1//COMMIT_MSG@11 PS1, Line 11: start : many "mobile" Oh, wow, I thought you're running a single process with multiple 'ms' instances configured... BTW: why not? https://gerrit.osmocom.org/#/c/12208/1//COMMIT_MSG@16 PS1, Line 16: once vty.c has a option to specify the address and : optionally the port. It's already possible to specify the VTY bind address, so maybe we should introduce a new option to change the bind port instead of reverting? I am a bit afraid that this (to be reverted) change would be forgotten. -- To view, visit https://gerrit.osmocom.org/12208 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie89bc16b667dbe05baa76cfa4f86b4946f8019e8 Gerrit-Change-Number: 12208 Gerrit-PatchSet: 1 Gerrit-Owner: Holger Freyther <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Sat, 08 Dec 2018 00:47:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
