Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12221 )
Change subject: Use explicit parameter for sgsn_auth_init() ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/12221/1/src/gprs/sgsn_auth.c File src/gprs/sgsn_auth.c: https://gerrit.osmocom.org/#/c/12221/1/src/gprs/sgsn_auth.c@a43 PS1, Line 43: Where did this sgsn var come from before? I see you declare a new var in sgsn which get allocated, but you are not removing the one being used here? https://gerrit.osmocom.org/#/c/12221/1/tests/sgsn/sgsn_test.c File tests/sgsn/sgsn_test.c: https://gerrit.osmocom.org/#/c/12221/1/tests/sgsn/sgsn_test.c@51 PS1, Line 51: struct sgsn_instance *sgsn = &sgsn_inst; Ah here it is. Why is this being removed in this commit if we allocate a new one in main? -- To view, visit https://gerrit.osmocom.org/12221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeba371234680f33ad35afbfffce9dca185228c1 Gerrit-Change-Number: 12221 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 10 Dec 2018 15:52:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
