Max has posted comments on this change. ( https://gerrit.osmocom.org/12221 )
Change subject: Use explicit parameter for sgsn_auth_init() ...................................................................... Patch Set 2: > Patch Set 2: Code-Review+1 > > Can you provide some patches to get rid of the global variable then? or at > least keep it only for VTY if needed. That would require changing gmm_attach_timer_cb() which probably would in turn require changes to struct sgsn_mm_ctx which overall seems like pretty intrusive change. I've updated the patch to keep old global variable to minimize the changes. -- To view, visit https://gerrit.osmocom.org/12221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibeba371234680f33ad35afbfffce9dca185228c1 Gerrit-Change-Number: 12221 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-Comment-Date: Tue, 11 Dec 2018 09:31:53 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
