Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/12177 )
Change subject: make gsup ipa name configurable in osmo-msc.cfg ...................................................................... Patch Set 4: Code-Review+1 (3 comments) https://gerrit.osmocom.org/#/c/12177/4/src/libmsc/msc_vty.c File src/libmsc/msc_vty.c: https://gerrit.osmocom.org/#/c/12177/4/src/libmsc/msc_vty.c@464 PS4, Line 464: . Usually, we don't use dots in VTY, in particular for a single sentence. https://gerrit.osmocom.org/#/c/12177/4/src/libvlr/vlr.c File src/libvlr/vlr.c: https://gerrit.osmocom.org/#/c/12177/4/src/libvlr/vlr.c@1225 PS4, Line 1225: Unrelated ws. https://gerrit.osmocom.org/#/c/12177/4/tests/msc_vlr/msc_vlr_tests.c File tests/msc_vlr/msc_vlr_tests.c: https://gerrit.osmocom.org/#/c/12177/4/tests/msc_vlr/msc_vlr_tests.c@564 PS4, Line 564: ws -- To view, visit https://gerrit.osmocom.org/12177 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I317d6c59f77e92fbb2b875a83dc0ec2fa5cb6006 Gerrit-Change-Number: 12177 Gerrit-PatchSet: 4 Gerrit-Owner: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <s...@stsp.name> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Mon, 10 Dec 2018 16:08:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
